TRT-2254: extract Operator Progressing / Degraded Counts and Timing #30449
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jianlinliu: This pull request references TRT-2254 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Job Failure Risk Analysis for sha: f01fda0
|
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 11e2b1c
|
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade |
|
@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fe5001a0-b94a-11f0-82fa-e1d6c7ee712e-0 |
|
@jianlinliu: This pull request references TRT-2254 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test unit |
|
/test e2e-aws-ovn-microshift-serial |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade |
|
@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3a563760-b9ea-11f0-8835-258702823538-0 |
|
/test e2e-gcp-ovn |
|
From the metrics autodl json file, it was generated as expectation. |
| if len(metrics) > 0 { | ||
| rows := generateRowsFromMetrics(metrics) | ||
| dataFile := dataloader.DataFile{ | ||
| TableName: "operator_state_metrics", |
There was a problem hiding this comment.
I'm wondering if instead of the generic "Metric" we should have defined "Count", "TotalSeconds" and maybe "MinSeconds" and "MaxSeconds" instead of "IndividualDurationSeconds". Will see if others have thoughts on this.
There was a problem hiding this comment.
I think the consensus was to make this a single row per operator/condition tracking
"Count", "TotalSeconds" and "MaxIndividualDurationSeconds"
| if err := dataloader.WriteDataFile(fileName, dataFile); err != nil { | ||
| return fmt.Errorf("failed to write operator state metrics: %w", err) | ||
| } | ||
| fmt.Printf("--->Write operator state metrics to %s successfully.\n", fileName) |
There was a problem hiding this comment.
I like to encourage the use of logrus.Infof for this, clean syntax and ensures we get timestamps for debugging purposes.
There was a problem hiding this comment.
Ah, actually that line was added for debugging, sure, I will update it to use logrus.Infof.
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade |
|
@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/08e8c8c0-baf6-11f0-985c-0d8c3a5eab3d-0 |
|
/cc |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b7e34ea
New tests seen in this PR at sha: b7e34ea
|
| Schema: map[string]dataloader.DataType{ | ||
| "Operator": dataloader.DataTypeString, | ||
| "State": dataloader.DataTypeString, | ||
| "Count": dataloader.DataTypeFloat64, |
There was a problem hiding this comment.
What do you think about DataTypeInteger for Count, TotallSeconds and MaxIndividualDurationSeconds? I don't think we are worried about precision beyond second.
There was a problem hiding this comment.
Rethinking this actually. Count would make sense as an integer. Our intervals show the time as whole seconds but it makes sense for the data we collect to be more precise so leaving the time values as Float64 is probably good.
There was a problem hiding this comment.
Sure. Make sense.
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade |
|
@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea266120-bb10-11f0-9b5f-81cec0dd33d4-0 |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 6c5eecb
New tests seen in this PR at sha: 6c5eecb
|
|
/retest-required |
|
/test e2e-aws-ovn-fips |
|
/test e2e-aws-ovn-microshift |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianlinliu, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jianlinliu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
extract operator Progressing / Degraded Counts and Timing from intervals, collect them and save them into a auto data loader json file for historical analysis.