Skip to content

OCPBUGS-66072: [release-4.20] net(virt) remove virtctl if not correctly retrieved #30538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 11, 2025
Merged

OCPBUGS-66072: [release-4.20] net(virt) remove virtctl if not correctly retrieved #30538

openshift-merge-bot merged 1 commit into from
Dec 11, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 26, 2025

This is an automated cherry-pick of #30485

/assign qinqon

@qinqon
net(virt): Remove virtctl if not correctly retrieved
77988f4 
If the virtctl download/unpack fails in the middle the downloadFile can
leave a corrupted file behind, this change ensure file is removed if
function do not correctly finish.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2025
Merged
@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/retitle NO-JIRA: [release-4.20] net(virt) remove virtctl if not correctly retrieved

@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/jira refresh

@openshift-ci openshift-ci bot changed the title [release-4.20] NO-JIRA: net(virt) remove virtctl if not correctly retrieved NO-JIRA: [release-4.20] net(virt) remove virtctl if not correctly retrieved Nov 26, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@qinqon: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maiqueb
Copy link
Contributor

maiqueb commented Nov 26, 2025

I don't think you can use NO-JIRA here. A backport requires the jira/valid-bug label, which requires an OCPBUG AFAIU.

@qinqon

@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/retitle OCPBUGS-66072: [release-4.20] net(virt) remove virtctl if not correctly retrieved

@openshift-ci openshift-ci bot changed the title NO-JIRA: [release-4.20] net(virt) remove virtctl if not correctly retrieved OCPBUGS-66072: [release-4.20] net(virt) remove virtctl if not correctly retrieved Nov 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-66072, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-66072 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #30485

/assign qinqon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 26, 2025
@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@qinqon: This pull request references Jira Issue OCPBUGS-66072, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-66072 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@qinqon: This pull request references Jira Issue OCPBUGS-66072, which is invalid:

  • expected Jira Issue OCPBUGS-66072 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@qinqon: This pull request references Jira Issue OCPBUGS-66072, which is invalid:

  • expected dependent Jira Issue OCPBUGS-66073 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@qinqon: This pull request references Jira Issue OCPBUGS-66072, which is invalid:

  • expected dependent Jira Issue OCPBUGS-66073 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@qinqon: This pull request references Jira Issue OCPBUGS-66072, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-66073 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-66073 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 26, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, openshift-cherrypick-robot, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@qinqon
Copy link
Contributor

qinqon commented Nov 26, 2025

/retest-required

1 similar comment
@qinqon
Copy link
Contributor

qinqon commented Nov 27, 2025

/retest-required

@qinqon
Copy link
Contributor

qinqon commented Dec 10, 2025

/verified

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

@qinqon: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor

qinqon commented Dec 10, 2025

/test help

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

@qinqon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-jenkins

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial-1of2

/test e2e-aws-ovn-serial-2of2

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test e2e-vsphere-ovn

/test e2e-vsphere-ovn-upi

/test images

/test lint

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-serial-ipsec

/test e2e-aws-ovn-serial-publicnet-1of2

/test e2e-aws-ovn-serial-publicnet-2of2

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-csi

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial-1of2

/test e2e-gcp-fips-serial-2of2

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial-1of2

/test e2e-gcp-ovn-techpreview-serial-2of2

/test e2e-gcp-ovn-usernamespace

/test e2e-hypershift-conformance

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-bgp-virt-dualstack

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-bgp

/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial-1of2

/test e2e-metal-ipi-serial-2of2

/test e2e-metal-ipi-serial-ovn-ipv6-1of2

/test e2e-metal-ipi-serial-ovn-ipv6-2of2

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-metal-ovn-two-node-arbiter

/test e2e-metal-ovn-two-node-fencing

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-fips

pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-microshift

pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-serial-1of2

pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-serial-2of2

pull-ci-openshift-origin-release-4.20-e2e-gcp-ovn

pull-ci-openshift-origin-release-4.20-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-release-4.20-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-release-4.20-e2e-vsphere-ovn

pull-ci-openshift-origin-release-4.20-e2e-vsphere-ovn-upi

pull-ci-openshift-origin-release-4.20-images

pull-ci-openshift-origin-release-4.20-lint

pull-ci-openshift-origin-release-4.20-okd-scos-images

pull-ci-openshift-origin-release-4.20-unit

pull-ci-openshift-origin-release-4.20-verify

pull-ci-openshift-origin-release-4.20-verify-deps
Details

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qinqon
Copy link
Contributor

qinqon commented Dec 10, 2025

/test e2e-metal-ipi-ovn-bgp-virt-dualstack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-bgp-virt-dualstack 77988f4 link false /test e2e-metal-ipi-ovn-bgp-virt-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qinqon
Copy link
Contributor

qinqon commented Dec 11, 2025

/verify by "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip when the VM attached to a secondary UDN is restarted", @qinqon

@qinqon
Copy link
Contributor

qinqon commented Dec 11, 2025

/verify by "should keep ip when the VM attached to a secondary UDN is restarted", @qinqon

@qinqon
Copy link
Contributor

qinqon commented Dec 11, 2025

/verified by "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip when the VM attached to a secondary UDN is restarted", @qinqon

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

@qinqon: This PR has been marked as verified by "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip when the VM attached to a secondary UDN is restarted",@qinqon.

Details

In response to this:

/verified by "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip when the VM attached to a secondary UDN is restarted", @qinqon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qinqon
Copy link
Contributor

qinqon commented Dec 11, 2025

/retest-required

1 similar comment
@qinqon
Copy link
Contributor

qinqon commented Dec 11, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

/retest-required

Remaining retests: 0 against base HEAD 3be963e and 2 for PR HEAD 77988f4 in total

@openshift-merge-bot openshift-merge-bot bot merged commit f68cadc into openshift:release-4.20 Dec 11, 2025
17 of 20 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-66072
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66072 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #30485

/assign qinqon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkadeepsen arkadeepsen Awaiting requested review from arkadeepsen

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@qinqon qinqon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @qinqon @maiqueb @kyrtapz