OCPBUGS-77002: Remove temporarily skip of MCO tests creating custom MCPs in RHEL10 suites

[isabella-janssen]

This removes the temporary skip of MCO tests creating custom MCPs in RHEL-10 suites introduced in #30793. With the MCO implementation of openshift/machine-config-operator#5697, custom MCPs now inherit the OSImageStream from the worker MCP, if one is set. This means that creating custom MCPs in these tests should be non-disruptive, as they are in the RHEL-9 suites.

To verify, the serial RHEL-10 test suites should all pass.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

Removed two private helper functions (isRHEL10 and skipOnRHEL10BeforeMar11) from the machine config test suite that previously skipped tests conditionally based on RHEL10 targeting and a March 11, 2026 date threshold. Corresponding skip calls were removed from test branches, allowing those tests to execute unconditionally.

Changes

Cohort / File(s)	Summary
Helper function cleanup test/extended/machine_config/helpers.go	Removed private helper functions isRHEL10 and skipOnRHEL10BeforeMar11 that performed RHEL10 detection and date-based test skipping logic.
Test skip removal test/extended/machine_config/machine_config_node.go	Removed conditional skip calls (skipOnRHEL10BeforeMar11) from two test branches, eliminating skips for RHEL10 dual-stream and pre-March 11 date conditions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names use static, deterministic strings without dynamic content like timestamps, UUIDs, or runtime values.
Test Structure And Quality	✅ Passed	The PR removes temporary date-based skip logic, improving test quality by eliminating problematic patterns. Remaining code demonstrates solid practices: proper Ginkgo structure, timeout-aware wait functions, comprehensive assertions, and infrastructure-based skip functions.
Title check	✅ Passed	The title accurately summarizes the main change: removing temporary skip conditions for MCO tests that create custom MCPs in RHEL10 suites, matching the raw_summary which shows removal of skipOnRHEL10BeforeMar11 calls.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/machine_config/OWNERS [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-1of3 openshift/machine-config-operator#5697

[openshift-ci]

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e5745130-198b-11f1-9d4f-fb2221c027fa-0

[isabella-janssen]

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-2of3 openshift/machine-config-operator#5697

[openshift-ci]

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed76a400-198b-11f1-8a30-b929a0a0432d-0

[isabella-janssen]

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-3of3 openshift/machine-config-operator#5697

[openshift-ci]

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f27c3190-198b-11f1-8dd4-0f4d077ca52f-0

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-77002, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary by CodeRabbit

• Tests
• Removed conditional test skipping logic for RHEL10 scenarios and date-based conditions. Tests will now execute in previously skipped scenarios, improving test coverage across different cluster configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-77002, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-3of3

[openshift-ci]

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-rhcos10-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3432d060-1bd7-11f1-91c2-a3b2bb16baa9-0

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[isabella-janssen]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-rhcos10-serial-1of2

[openshift-ci]

@isabella-janssen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command