Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: denylist: add ext.config.shared.containers.quadlet #1746

Closed
wants to merge 1 commit into from

Conversation

jbtrystram
Copy link
Contributor

See #1745

@openshift-ci openshift-ci bot requested review from c4rt0 and gursewak1997 February 13, 2025 13:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@travier
Copy link
Member

travier commented Feb 13, 2025

/retitle NO-JIRA: denylist: add ext.config.shared.containers.quadlet
/lgtm
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot changed the title denylist: add ext.config.shared.containers.quadlet NO-JIRA: denylist: add ext.config.shared.containers.quadlet Feb 13, 2025
@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 13, 2025
@openshift-ci-robot
Copy link

@jbtrystram: This pull request explicitly references no jira issue.

In response to this:

See #1745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2025
@travier
Copy link
Member

travier commented Feb 13, 2025

/test images

Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, jbtrystram, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [c4rt0,jbtrystram,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Feb 13, 2025

I think we just need #1730 instead of this?

@dustymabe
Copy link
Member

I think we just need #1730 instead of this?

yes. it includes coreos/fedora-coreos-config#3343

@jbtrystram
Copy link
Contributor Author

ah, thanks @jlebon ! Sorry I missed that.
I'll close this then

@jbtrystram jbtrystram closed this Feb 13, 2025
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

@jbtrystram: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images d19b039 link true /test images
ci/prow/e2e-aws d19b039 link false /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants