Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fix function tests with new build-root image #56544

Closed
wants to merge 3 commits into from

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 11, 2024

Testing built-dockerfile without chmod

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@creydr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-kn-plugin-func-release-next-e2e-oncluster-test openshift-knative/kn-plugin-func presubmit Ci-operator config changed
pull-ci-openshift-knative-kn-plugin-func-release-next-unit openshift-knative/kn-plugin-func presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@creydr
Copy link
Member Author

creydr commented Sep 11, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@creydr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: creydr
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Sep 11, 2024

Reverted changes in release-next (openshift-knative/kn-plugin-func#883). Will rerun...

/pj-rehearse pull-ci-openshift-knative-kn-plugin-func-release-next-unit

@openshift-ci-robot
Copy link
Contributor

@creydr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-knative/kn-plugin-func/release-next/e2e-oncluster-test 299d421 link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-func-release-next-e2e-oncluster-test
ci/rehearse/openshift-knative/kn-plugin-func/release-next/unit 299d421 link unknown /pj-rehearse pull-ci-openshift-knative-kn-plugin-func-release-next-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@creydr creydr closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants