Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2017: Bump all deps for 4.18 #65

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

rhrmo
Copy link
Contributor

@rhrmo rhrmo commented Nov 5, 2024

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@rhrmo: This pull request references STOR-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go
  • Added spec.unhealthyEvictionPolicy: AlwaysAllow to all pdbs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 6, 2024

/test operator-e2e-vault

1 similar comment
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 7, 2024

/test operator-e2e-vault

pkg/operator/starter.go Show resolved Hide resolved
return nil, nil
}
return &ret.Status.OperatorStatusApplyConfiguration, nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a pain to copy-paste these extractors into each operator. One alternative (that can be done later), is to consolidate them in a single exported package, allowing all operators to re-use them. That place could be library-go or (even better IMO) csi-operator.

go.mod Show resolved Hide resolved
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 8, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 8, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

@rhrmo: This pull request references STOR-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 14, 2024

/retest

@mpatlasov
Copy link
Contributor

/lgtm
/approve
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 14, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@duanwei33
Copy link

/test operator-e2e-vault

@ropatil010
Copy link

/retest

@ropatil010
Copy link

ropatil010 commented Nov 18, 2024

From the logs the 2 tc are flake and both are related to time sync issues.
not ok 1 install vault provider
not ok 6 CSI inline volume test with pod portability - rotation succeeds

Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@rhrmo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e-vault 3f4cae3 link false /test operator-e2e-vault

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ropatil010
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2024

@rhrmo: This pull request references STOR-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3ed1106 into openshift:main Nov 18, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants