Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-545: Improve handling of metrics configuration #2485

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WINC-545: Improve handling of metrics configuration #2485

wants to merge 2 commits into from
+290 −698

Commits on Nov 6, 2024

  1. WMCO does not create and manage endpoints 

    This commit removes the code responsible for
creating and managing metric endpoints object.
There is an endpoint named kubelet in the
kube-system namespace which contains all the
node IP addresses. WMCO can rely on this endpoint
and create the serviceMonitor which will change
the port from 10250 to 9182 which is our desired
metric port for the windows-exporter service
    @mansikulkarni96
    mansikulkarni96 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    03aacdc View commit details
    Browse the repository at this point in the history

  2. [controllers] Introduce metricController 

    This commit adds a new metricController that
watches the WMCO namespace to create service
monitor when monitoring is enabled.
Add namespace resource list and watch rbac.
    @mansikulkarni96
    mansikulkarni96 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    25bf04c View commit details
    Browse the repository at this point in the history