Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backmatter intro for 1.6 #560

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

jdinan
Copy link
Collaborator

@jdinan jdinan commented Nov 7, 2024

No description provided.

Signed-off-by: James Dinan <jdinan@nvidia.com>
Copy link

@lstewart lstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Signed-off-by: James Dinan <jdinan@nvidia.com>
@jdinan
Copy link
Collaborator Author

jdinan commented Nov 7, 2024

Closes #446

Copy link

@lstewart lstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that resolves the #446 issue

davidozog

This comment was marked as off-topic.

@lstewart
Copy link

lstewart commented Nov 7, 2024

Dave's changes look OK, but we're in the weeds and should stop and ship it.

@davidozog
Copy link
Collaborator

Dave's changes look OK, but we're in the weeds and should stop and ship it.

Funny, I was just thinking a similar thing; and I'm not completely confident with the nits anyway. I've retracted the suggestions, @jdinan please feel free to ping if curious, but truly this is good to go.

Co-authored-by: David Ozog <david.m.ozog@gmail.com>
@jdinan jdinan merged commit 3a8a05c into openshmem-org:main Nov 8, 2024
1 check passed
@jdinan jdinan deleted the changes-1.6 branch November 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants