Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OPENSIM_ASSERT in ConstantCurvatureJoint::ConstantCurvatureJointImpl #3614

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

nickbianco
Copy link
Member

@nickbianco nickbianco commented Nov 17, 2023

Fixes issue #3610

Brief summary of changes

Replaces calls to OPENSIM_ASSERT_FRMOBJ with OPENSIM_ASSERT in ConstantCurvatureJoint::ConstantCurvatureJointImpl since it is a helper function that does not derive from Object.

Testing I've completed

Successfully created a Debug build without error.

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...build fix.

This change is Reviewable

@nickbianco nickbianco requested a review from aymanhab November 17, 2023 00:06
@nickbianco nickbianco changed the title Replace OPENSIM_ASSERT_FRMOBJ with OPENSIM_ASSERT in ConstantCurvatureJoint::ConstantCurvatureJointImpl Use OPENSIM_ASSERT in ConstantCurvatureJoint::ConstantCurvatureJointImpl Nov 17, 2023
@nickbianco nickbianco removed the request for review from aymanhab November 17, 2023 07:01
@nickbianco
Copy link
Member Author

Thanks @tkuchida!

@nickbianco nickbianco merged commit 846d488 into main Nov 17, 2023
@nickbianco nickbianco deleted the constant_curvature_joint_fix branch November 17, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants