Small FFM race fix and small cleanup #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were carried over from the JNI implementation, where they were needed to prevent segfaults. With FFM, each of the affected variables is passed to arena.allocateFrom(), which properly throws a NullPointerException on null. That seems more correct than returning a method-specific sentinel value, since none of these methods should ever receive null in normal operation. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
When OpenSlide returns a pointer to a structure inside the openslide_t, we need to hold the OpenSlideRef lock until we're done copying out the returned data. This prevents another thread from closing the openslide_t out from under us. Fixes: 6d10501 ("Push locking down into OpenSlideFFM") Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OpenSlide returns a pointer to a structure inside the
openslide_t, we need to hold theOpenSlideReflock until we're done copying out the returned data. This prevents another thread from closing theopenslide_tout from under us.Drop redundant
OpenSlideFFMnull checks. These were carried over from the JNI implementation, where they were needed to prevent segfaults. With FFM, each of the affected variables is passed toarena.allocateFrom(), which properly throws aNullPointerExceptiononnull. That seems more correct than returning a method-specific sentinel value, since none of these methods should ever receivenullin normal operation.