Refactored struct

[ghost]

• Refactored dateConverter with new Date struct.
• Added a Calendar flag in Date struct.
• Added Weekday Method to get week.
• Adding tests of the method.

[sugat009]

@thearjunneupane Can you please squash your commits so that this PR only has 1 commit?

[aj3sh]

Hi @thearjunneupane, I appreciate your contribution. From my perspective, I don't see a need for this refactoring.

The dateConverter module is very lightweight, and I prefer to keep it that way. All the detailed features are available in the nepalitime module, including the weekday. Here are some examples of date conversion using the nepalitime module.

// english to nepali
enTime1 := time.Date(2023, 1, 29, 0, 0, 0, 0, nepalitime.GetNepaliLocation())
npTime1, _ := nepalitime.FromEnglishTime(enTime1)
fmt.Println(npTime1.Year(), npTime1.Month(), npTime1.Day(), npTime1.Weekday())

// nepali to english
npTime2, _ := nepalitime.Date(2079, 10, 15, 14, 29, 6, 7)
enTime2 := npTime2.GetEnglishTime()
fmt.Println(enTime2.Year(), enTime2.Month(), enTime2.Day(), enTime2.Weekday())

cc: @sugat009

[ghost]

Hi @aj3sh
Thank you for your feedback. I understand your perspective on keeping the dateConverter module lightweight, and I appreciate your preference for simplicity.
After reviewing your examples with the nepalitime module, I can see that it provides comprehensive date conversion features, including the weekday, which meets our requirements effectively. Therefore, I agree that there might not be a necessity for the additional refactoring.

[aj3sh]

@thearjunneupane, go-nepali is still in beta and requires further enhancements and improvements. For instance, we can simplify the initialization process of nepalitime as mentioned in my example. Additionally, not all features are covered in the documentation.

Feel free to contribute and create an issue if you believe any enhancements are necessary. We are open to discussion.