Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix weekday directive in README #73

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

sumanchapai
Copy link
Contributor

@sumanchapai sumanchapai commented Nov 24, 2023

Description

Fix the typo in the documentation regarding the weekday directive.

Related Issue

[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • I have used semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have used pre-commit hooks.
  • I have added/updated the necessary documentation on README.md.
  • I have updated CHANGELOG.md for the significant changes.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.
  • My pull request has a clear title and description.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

sugat009
sugat009 previously approved these changes Nov 28, 2023
@aj3sh aj3sh self-requested a review November 28, 2023 08:29
@aj3sh
Copy link
Member

aj3sh commented Nov 28, 2023

@sumanchapai, Thanks for the contribution. However, there are a few things that need to be updated.

  1. Please use semantic commit messages.
  2. Please update the description of this PR.

@sugat009 sugat009 dismissed their stale review November 28, 2023 08:40

Description not as per contribution guide and commit not semantic

@sumanchapai sumanchapai changed the title Fix weekday directive in README docs: fix weekday directive in README Nov 30, 2023
@aj3sh aj3sh merged commit 4127b12 into opensource-nepal:main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants