Convert string literals containing SJIS characters to Java string literals #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutaro-sakamoto
force-pushed
the
string-hex
branch
from
2665eda to
579c31e
Compare
Merged
yutaro-sakamoto
requested review from
kio-watanabe
and removed request for
n-isaka
kio-watanabe
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the readability of generated Java code, this pull request modifies codegen.c so that
cobjconverts string literals containing no non-SJIS character to ordinary Java string literals.For example, the older compiler converts
"日本語"in COBOL source code toCobolUtil.toBytes((byte)0x93, (byte)0xfa, (byte)0x96, (byte)0x7b, (byte)0x8c, (byte)0xea)in Java source code.This pull request causes the compiler to converts "日本語" in COBOL source code to
CobolUtil.stringToBytes("日本語")