Skip to content

Documentation for Federated (OIDC) Keystone adoption#1062

Open
xek wants to merge 2 commits intoopenstack-k8s-operators:mainfrom
xek:federation_adoption_docs
Open

Documentation for Federated (OIDC) Keystone adoption#1062
xek wants to merge 2 commits intoopenstack-k8s-operators:mainfrom
xek:federation_adoption_docs

Conversation

@xek
Copy link
Contributor

@xek xek commented Sep 25, 2025

  • Documentation for Federated (OIDC) Keystone adoption

Jira: https://issues.redhat.com/browse/OSPRH-19963
Jira: https://issues.redhat.com/browse/OSPRH-19960

@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign archana203 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 11, 2025
@github-actions github-actions bot closed this Oct 18, 2025
@xek xek reopened this Feb 5, 2026
@xek xek marked this pull request as ready for review February 5, 2026 09:31
@xek xek force-pushed the federation_adoption_docs branch from a9ee74c to 47064a9 Compare February 5, 2026 09:37
@github-actions github-actions bot removed the Stale label Feb 6, 2026
@jistr
Copy link
Contributor

jistr commented Feb 6, 2026

Looks good, also adding @klgill

@jistr jistr requested a review from klgill February 6, 2026 12:05
Copy link
Contributor

@klgill klgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xek Please let me know if you have questions about any of my edits. Thanks!

@@ -0,0 +1,117 @@
_mod-docs-content-type: PROCEDURE
[id='configuring-federation-for-keystone_{context}']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[id='configuring-federation-for-keystone_{context}']
[id="configuring-federation-for-keystone_{context}"]

@@ -0,0 +1,117 @@
_mod-docs-content-type: PROCEDURE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_mod-docs-content-type: PROCEDURE
:_mod-docs-content-type: PROCEDURE


= Configuring OIDC federation for the Identity service

To let {identity_service_first_ref} trust an external OpenID Connect (OIDC) identity provider, apply the federation configuration and verify that federated users can authenticate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To let {identity_service_first_ref} trust an external OpenID Connect (OIDC) identity provider, apply the federation configuration and verify that federated users can authenticate.
To allow the {identity_service_first_ref} to trust an external OpenID Connect (OIDC) identity provider, apply the federation configuration and verify that federated users can authenticate.

"Allow" seems like a stronger verb than "let."

+
----
$ oc create secret generic keycloakca \
--from-file=KeyCloakCA=keycloak-ca.crt -n openstack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--from-file=KeyCloakCA=keycloak-ca.crt -n openstack
--from-file=KeyCloakCA=<keycloak-ca.crt> -n openstack

--from-file=KeyCloakCA=keycloak-ca.crt -n openstack
----
+
* Replace `keycloak-ca.crt` with the path to the CA file you want to use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Replace `keycloak-ca.crt` with the path to the CA file you want to use.
where:
`<keycloak-ca.crt>`:: Replace with the path to the CA file you want to use.

customConfigSecret: keystone-httpd-override
----
+
* Ensure you merge the patch with any existing custom configuration for the {identity_service}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying that customers should update this example with their own existing custom configuration for the {identity_service}?

$ openstack token issue
----
+
This command should return an access token issued for the federated user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This command should return an access token issued for the federated user.
This command should return an access token that is issued for the federated user.

OS_ACCESS_TOKEN=$(openstack token issue -f value -c id) \
openstack project show <project id>
----
+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+
+
where:
`<project_id>`:: Replace with the ID of your OpenStack project.

@xek Is the description of this value accurate?

OS_AUTH_URL=https://keystone-public-openstack.apps-crc.testing/v3 \
OS_AUTH_TYPE=v3oidcaccesstoken \
OS_ACCESS_TOKEN=$(openstack token issue -f value -c id) \
openstack project show <project id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openstack project show <project id>
openstack project show <project_id>

openstack project show <project id>
----
+
A successful response confirms that the federated OIDC configuration is active on the podified Keystone deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xek Can you provide an example of a successful response?
Also, what should customers do if the response fails?

- Fix _mod-docs-content-type attribute syntax (add colon prefix)
- Use double quotes for id attribute
- Change "To let" to "To allow" for stronger verb
- Use angle brackets for placeholder values in commands
- Replace bullet-point replacements with "where:" definition lists
- Change "required for" to "that are required for"
- Add detailed descriptions for client_secret, crypto_passphrase placeholders
- Fix "access token issued" to "access token that is issued"
- Fix "<project id>" to "<project_id>" with where clause
@github-actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 25, 2026
@jistr jistr removed the Stale label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants