-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ubi9 image for aee #805
Conversation
Not sure if we can create an image based on |
we can use ansible-builder: |
openstack_ansibleee/Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM ghcr.io/ansible/community-ansible-dev-tools:v24.10.0 as builder | |||
FROM registry.redhat.io/ansible-automation-platform-24/ee-minimal-rhel9:1.0 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a login, so I don't think we can use this upstream.
50b802a
to
204daa0
Compare
cdc213c
to
a8222f0
Compare
The current adt image is with fedora base image that installs packages using pip without constraints and prone to be broken with latest changes in packages. We also probably need a way to control what should be installed with pip and dnf when using ubi9. Signed-off-by: rabi <ramishra@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
I like this, and the size reduction is nice. Given there's no ee-minimal image available upstream on quay.io, using ubi9 seems pretty reasonable.
I'll leave it to @fao89 to approve, just to make sure he doesn't have any concerns.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
15de57d
into
openstack-k8s-operators:main
The current image is a base fedora image that installs packages using pip and prone to be broken with latest changes in packages.
This uses ubi9-minimal as the base image and also reduces the image size by ~2/3rd (455 MB vs 167MB).