Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nova]Add GMR triggering support #34

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[nova]Add GMR triggering support #34

merged 1 commit into from
Dec 21, 2023

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Dec 20, 2023 •
edited by openshift-ci bot
Loading

@gibizer gibizer force-pushed the gmr-nova branch 2 times, most recently from ccc988d to b886d8b Compare December 20, 2023 13:22
@gibizer
Copy link
Contributor Author

gibizer commented Dec 20, 2023

Placement has no GMR support at all upstream.

Akrog
Akrog requested changes Dec 20, 2023
View reviewed changes
collection-scripts/gather_trigger_gmr Show resolved Hide resolved
collection-scripts/gather_trigger_gmr Outdated Show resolved Hide resolved
Akrog
Akrog approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/21571cc5d42f44d782d44bbfeb6bd393

❌ podified-multinode-edpm-deployment-crc FAILURE in 41m 33s

@gibizer
Copy link
Contributor Author

gibizer commented Dec 20, 2023

recheck

TASK [edpm_prepare : Get CA bundle data _raw_params=oc get secret combined-ca-bundle -n openstack -o "jsonpath={.data.tls-ca-bundle\.pem}" --ignore-not-found] ***
...[snip]...
 You must be logged in to the server (Unauthorized)"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f5c0f93 into openstack-k8s-operators:main Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akrog Akrog Akrog approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@stuggi stuggi Awaiting requested review from stuggi

@fmount fmount Awaiting requested review from fmount

@mrkisaolamb mrkisaolamb Awaiting requested review from mrkisaolamb

Assignees

@Akrog Akrog

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibizer @Akrog @fmount