Fix qti-match to use case-insensitive comparison for string base-type… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… responses When qti-match is used with a response declaration of base-type="string" (common pattern for text entry items with qti-correct), the comparison was using strict equality via deepEqual, making "Wicked king" fail to match "wicked king". Now detects string base-type responses and performs case-insensitive comparison, while keeping identifier and other base types case-sensitive. https://claude.ai/code/session_01HaL7GMnrzkqhouoc6h1pcc
…lities All case-insensitive string comparison logic was scattered across 4 call sites, each doing its own toLowerCase() pattern. Added stringEquals and stringIncludes to equality.ts (defaulting to case-insensitive) and refactored all consumers to use them: - evaluateStringMatch / evaluateSubstring in string.ts - evaluateMatch in comparison.ts - getMappedValue in responseProcessing.ts https://claude.ai/code/session_01HaL7GMnrzkqhouoc6h1pcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… responses
When qti-match is used with a response declaration of base-type="string" (common pattern for text entry items with qti-correct), the comparison was using strict equality via deepEqual, making "Wicked king" fail to match "wicked king". Now detects string base-type responses and performs case-insensitive comparison, while keeping identifier and other base types case-sensitive.
https://claude.ai/code/session_01HaL7GMnrzkqhouoc6h1pcc