Skip to content

Revert "Fix qti-string-match and qti-substring defaulting to case-sensitive" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomWoodward merged 1 commit into from
Feb 7, 2026
Merged

Revert "Fix qti-string-match and qti-substring defaulting to case-sensitive" #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cutie-core/src/lib/expressionEvaluator/string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function evaluateSubstring(
variables: Record<string, unknown>,
subEvaluate: SubEvaluate
): boolean {
const caseSensitive = element.getAttribute('case-sensitive') === 'true';
const caseSensitive = element.getAttribute('case-sensitive') !== 'false';
const values: string[] = [];

for (const child of getChildElements(element)) {
Expand All @@ -39,7 +39,7 @@ export function evaluateStringMatch(
variables: Record<string, unknown>,
subEvaluate: SubEvaluate
): boolean {
const caseSensitive = element.getAttribute('case-sensitive') === 'true';
const caseSensitive = element.getAttribute('case-sensitive') !== 'false';
const values: string[] = [];

for (const child of getChildElements(element)) {
Expand Down
44 changes: 0 additions & 44 deletions packages/cutie-core/src/lib/initializeState.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1869,50 +1869,6 @@ describe('initializeState', () => {
expect(state.variables.RESULT).toBe(true);
});

test('qti-string-match defaults to case-insensitive', () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<qti-assessment-item xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0"
identifier="string-match-default" title="String Match Default">
<qti-template-declaration identifier="RESULT" cardinality="single" base-type="boolean"/>
<qti-template-processing>
<qti-set-template-value identifier="RESULT">
<qti-string-match>
<qti-base-value base-type="string">Hello</qti-base-value>
<qti-base-value base-type="string">hello</qti-base-value>
</qti-string-match>
</qti-set-template-value>
</qti-template-processing>
<qti-item-body><p>Test</p></qti-item-body>
</qti-assessment-item>`;

const itemDoc = parser.parseFromString(xml, 'text/xml');
const state = initializeState(itemDoc);

expect(state.variables.RESULT).toBe(true);
});

test('qti-substring defaults to case-insensitive', () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<qti-assessment-item xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0"
identifier="substring-default" title="Substring Default">
<qti-template-declaration identifier="RESULT" cardinality="single" base-type="boolean"/>
<qti-template-processing>
<qti-set-template-value identifier="RESULT">
<qti-substring>
<qti-base-value base-type="string">Hello World</qti-base-value>
<qti-base-value base-type="string">hello</qti-base-value>
</qti-substring>
</qti-set-template-value>
</qti-template-processing>
<qti-item-body><p>Test</p></qti-item-body>
</qti-assessment-item>`;

const itemDoc = parser.parseFromString(xml, 'text/xml');
const state = initializeState(itemDoc);

expect(state.variables.RESULT).toBe(true);
});

test('evaluates qti-pattern-match operator', () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<qti-assessment-item xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0"
Expand Down
Loading