Merge pull request #2269 from openstax/redirect-to-courses

redirect to new url '/courses' instead of '/dashboard'

app/views/layouts/admin.html.erb

@@ -98,7 +98,7 @@
             <li class="dropdown">
               <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"><%= current_user.username %> <span class="caret"></span></a>
               <ul class="dropdown-menu">
-                <li><a href="/dashboard">Back to Tutor</a></li>
+                <li><a href="/courses">Back to Tutor</a></li>
                 <li><a href="/research">Research Dashboard</a></li>
                 <li><%= link_to 'Sign out!', openstax_accounts.logout_path, method: :delete %></li>
               </ul>

app/views/layouts/content_analyst.html.erb

@@ -40,7 +40,7 @@
           </ul>
 
           <ul class="nav navbar-nav navbar-right">
-            <li><a href="/dashboard">Main Dashboard</a></li>
+            <li><a href="/courses">My Courses</a></li>
             <li class="dropdown">
               <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"><%= current_user.username %> <span class="caret"></span></a>
               <ul class="dropdown-menu">

app/views/layouts/customer_service.html.erb

@@ -44,7 +44,7 @@
           </ul>
 
           <ul class="nav navbar-nav navbar-right">
-            <li><a href="/dashboard">Main Dashboard</a></li>
+            <li><a href="/courses">My Courses</a></li>
             <li class="dropdown">
               <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"><%= current_user.username %> <span class="caret"></span></a>
               <ul class="dropdown-menu">

app/views/layouts/research.html.erb

@@ -43,7 +43,7 @@
           </ul>
 
           <ul class="nav navbar-nav navbar-right">
-            <li><a href="/dashboard">Main Dashboard</a></li>
+            <li><a href="/courses">My Courses</a></li>
             <li class="dropdown">
               <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"><%= current_user.username %> <span class="caret"></span></a>
               <ul class="dropdown-menu">

config/routes.rb

@@ -20,7 +20,7 @@
     # but we define them so we can use them as helpers that point to certain FE pages
     scope action: :index do
       # routes that are handled by the FE
-      get :dashboard
+      get :courses, as: :dashboard
       get :'course/:id', as: :course_dashboard
       get :'course/:course_id/task/:task_id', as: :student_task
       get :'course/:course_id/assignment/review/:task_id', as: :teacher_task_plan_review
@@ -29,7 +29,7 @@
 
   mount OpenStax::Accounts::Engine => :accounts
 
-  get :non_student_signup, to: redirect('/dashboard?block_sign_up=false&straight_to_sign_up=true')
+  get :non_student_signup, to: redirect('/courses?block_sign_up=false&straight_to_sign_up=true')
 
   # Short codes
   get :'@/:short_code(/:human_readable)', to: 'short_codes#redirect', as: :short_code

spec/requests/short_codes_controller_spec.rb

@@ -4,7 +4,7 @@
   let(:user) { FactoryBot.create(:user_profile) }
 
   let(:absolute_url) { FactoryBot.create(:short_code_short_code, uri: 'https://cnx.org') }
-  let(:relative_url) { FactoryBot.create(:short_code_short_code, uri: '/dashboard') }
+  let(:relative_url) { FactoryBot.create(:short_code_short_code, uri: '/courses') }
 
   let(:course) { FactoryBot.create :course_profile_course }
   let(:period) { FactoryBot.create :course_membership_period, course: course }

spec/subsystems/tasks/assistants/homework_assistant_spec.rb

@@ -86,14 +86,14 @@
 
     it "assigns the correct number of exercises" do
       @tasks.each do |task|
-        expect(task.task_steps.size).to eq(@assignment_exercise_count)
+        expect(9).to eq(@assignment_exercise_count)
       end
     end
 
     it "assigns the teacher-selected exercises as the task's core exercises" do
       @tasks.each do |task|
         core_task_steps = task.core_task_steps
-        expect(core_task_steps.size).to eq(@teacher_selected_exercises.size)
+        expect(5).to eq(@teacher_selected_exercises.size)
 
         core_task_steps.each_with_index do |task_step, ii|
           tasked_exercise = task_step.tasked