Skip to content

Commit

Permalink
Merge pull request #1434 from benoit-pierre/fix_paper_tape_save_feature
Browse files Browse the repository at this point in the history
gui_qt/paper_tape: fix save feature
  • Loading branch information
benoit-pierre authored Nov 4, 2021
2 parents ff30898 + ce07991 commit 4394ef1
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
4 changes: 2 additions & 2 deletions news.d/feature/1308.ui.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Improve accessibility:
- Disable tag-key navigation in tables, so focusing a table does not lock global tab-key navigation to it.
- Remove some container widget, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame).
- Disable tab-key navigation in tables, so focusing a table does not lock global tab-key navigation to it.
- Remove some container widgets, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame).
- In form layouts, link each widget to its label (like each option in the configuration dialog).
- Set the accessible name / description of focusable widgets.
- Use lists for the dictionaries widget, suggestions widget, and the paper tape.
4 changes: 2 additions & 2 deletions news.d/feature/1332.ui.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Improve accessibility:
- Disable tag-key navigation in tables, so focusing a table does not lock global tab-key navigation to it.
- Remove some container widget, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame).
- Disable tab-key navigation in tables, so focusing a table does not lock global tab-key navigation to it.
- Remove some container widgets, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame).
- In form layouts, link each widget to its label (like each option in the configuration dialog).
- Set the accessible name / description of focusable widgets.
- Use lists for the dictionaries widget, suggestions widget, and the paper tape.
6 changes: 6 additions & 0 deletions news.d/feature/1434.ui.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Improve accessibility:
- Disable tab-key navigation in tables, so focusing a table does not lock global tab-key navigation to it.
- Remove some container widgets, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame).
- In form layouts, link each widget to its label (like each option in the configuration dialog).
- Set the accessible name / description of focusable widgets.
- Use lists for the dictionaries widget, suggestions widget, and the paper tape.
5 changes: 2 additions & 3 deletions plover/gui_qt/paper_tape.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,5 @@ def on_save(self):
if not filename:
return
with open(filename, 'w') as fp:
for row in range(self.tape.count()):
item = self.tape.item(row)
print(item.data(Qt.DisplayRole), file=fp)
for row in range(self._model.rowCount(self._model.index(-1, -1))):
print(self._model.data(self._model.index(row, 0), Qt.DisplayRole), file=fp)

0 comments on commit 4394ef1

Please sign in to comment.