Add test to controller and update scopes and filtering to handle edge…

… cases

app/controllers/notes_controller.rb

@@ -21,9 +21,9 @@ def index
     @title = t(".title", :user => @user.display_name)
     @page = (params[:page] || 1).to_i
     @page_size = 10
-
+    @notes = @notes.visible unless current_user&.moderator?
     @notes = @user.notes
-                  .filter_hidden_notes(current_user)
+                  # .filter_hidden_notes(current_user)
                   .filter_by_status(params[:status])
                   .filter_by_note_type(params[:note_type], @user.id)
                   .filter_by_date_range(params[:from], params[:to])

app/models/note.rb

@@ -58,12 +58,12 @@ class Note < ApplicationRecord
     case note_type
     when "commented"
       joins(:comments)
-        .where("notes.id IN (SELECT note_id FROM note_comments WHERE author_id != ?)", user_id)
+        .where("notes.id IN (SELECT note_id FROM note_comments WHERE author_id != ? OR author_id IS NULL)", user_id)
         .distinct
     when "submitted"
       joins(:comments)
         .where(:note_comments => { :author_id => user_id })
-        .where("note_comments.id = (SELECT MIN(id) FROM note_comments WHERE note_comments.note_id = notes.id)")
+        .where("note_comments.id = (SELECT MIN(nc.id) FROM note_comments nc WHERE nc.note_id = notes.id)")
         .distinct
     else
       all
@@ -72,8 +72,8 @@ class Note < ApplicationRecord
 
   scope :filter_by_date_range, lambda { |from, to|
     notes = all
-    notes = notes.where(:notes => { :created_at => DateTime.parse(from).. }) if from.present?
-    notes = notes.where(:notes => { :created_at => ..DateTime.parse(to) }) if to.present?
+    notes = notes.where(:created_at => DateTime.parse(from).beginning_of_day..) if from.present?
+    notes = notes.where(:created_at => ..DateTime.parse(to).end_of_day) if to.present?
     notes
   }