Move code that runs after user save from save_new_user to create method #5446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
save_new_user
does other things like redirects after the actual save. That obscures which pages are reachable from actions that callsave_new_user
, see #5431 (comment).Also
save_new_user
accesses referer in two different ways: as a function argument and asparams[:referer]
.Added test for clicking Sign Up, filling out email-login-password, clicking Sign Up, opening confirmation link from email.