Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code that runs after user save from save_new_user to create method #5446

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

AntonKhorev
Copy link
Collaborator

Currently save_new_user does other things like redirects after the actual save. That obscures which pages are reachable from actions that call save_new_user, see #5431 (comment).

Also save_new_user accesses referer in two different ways: as a function argument and as params[:referer].


Added test for clicking Sign Up, filling out email-login-password, clicking Sign Up, opening confirmation link from email.

@tomhughes
Copy link
Member

I mean it's not really clear why save_new_user exists when it's only called once but I guess this fine.

@tomhughes tomhughes merged commit 2042cb1 into openstreetmap:master Dec 29, 2024
22 checks passed
@AntonKhorev
Copy link
Collaborator Author

save_new_user was called from two different places when if was first introduced. The other was I think save after terms page.

@AntonKhorev AntonKhorev deleted the save-new-user branch December 30, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants