Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_logout_removes_session_token #5456

Conversation

AntonKhorev
Copy link
Collaborator

This test was about tokens that don't exist since #4535. That PR modified the test by removing the assert that checked the number of tokens in 4dff06a. Yet the test was kept although it doesn't do what it was supposed to do.

It also has post user_save_path that used to happen after post user_new_path when the terms page was shown during signups. This is not happening after #4455, and post user_save_path was removed from other tests in 1276fb9.

@tomhughes
Copy link
Member

Looks good to me, thanks.

@tomhughes tomhughes merged commit 402d7b9 into openstreetmap:master Jan 2, 2025
22 checks passed
@AntonKhorev AntonKhorev deleted the no-test_logout_removes_session_token branch January 3, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants