Remove account terms code unreachable for unregistered users #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
account-terms-for-active-users
branch
from
2e92eba to
e35760e
Compare
AntonKhorev
force-pushed
the
account-terms-for-active-users
branch
from
e35760e to
87e7f88
Compare
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the terms page was taken out of the signup process, its controller still had the code for this kind of use by unregistered users. Later I moved the page to
/account/termswhich implies that its only for active users, but I still haven't removed the code.Here I'm actually removing the unused code. Things like
redirect_to login_path(:referer => request.fullpath) if current_user.nil?are handled by abilities, only active users are able to access the terms.