Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use form with normal-sized button on follows show pages #5509

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Jan 17, 2025

Originally the make/remove friend pages contained a form:

<%= bootstrap_form_tag do |f| %>
<% if params[:referer] -%>
<%= f.hidden_field :referer, :value => params[:referer] %>
<% end -%>
<%= f.primary t(".button") %>
<% end %>

#5261 replaces these two pages with one /user/:user/follow page. That have doesn't have a form. Instead it has a link styled as a button. This is probably because there were multiple changes to paths during the development of that PR. But I don't know why it shouldn't be a true button with the paths we eventually settled on. Also the link has a small button css class on it. I don't know why the button that is the only thing on the page should be small. Probably it was a copypasted code from subscribe/unsubscribe buttons or something similar.

Before:
image

After:
image

@gravitystorm gravitystorm merged commit 8f25c09 into openstreetmap:master Jan 17, 2025
22 checks passed
@gravitystorm
Copy link
Collaborator

Merged, thanks!

@AntonKhorev AntonKhorev deleted the restore-follows-form branch January 17, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants