Use form with normal-sized button on follows show pages #5509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the make/remove friend pages contained a form:
openstreetmap-website/app/views/friendships/make_friend.html.erb
Lines 5 to 10 in 1732325
#5261 replaces these two pages with one
/user/:user/follow
page. That have doesn't have a form. Instead it has a link styled as a button. This is probably because there were multiple changes to paths during the development of that PR. But I don't know why it shouldn't be a true button with the paths we eventually settled on. Also the link has a small button css class on it. I don't know why the button that is the only thing on the page should be small. Probably it was a copypasted code from subscribe/unsubscribe buttons or something similar.Before:
After: