Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select user ids from reports using pluck #5578

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

AntonKhorev
Copy link
Collaborator

#4990 added the Reporter Users column. It uses reports to sort the users, but actually all it needs to get from the db are user ids. The existing version with map fetches the entire report by doing SELECT "reports".*. Here I'm replacing it with pluck that does SELECT "reports"."user_id".

@tomhughes
Copy link
Member

It should also mean that the uniq becomes part of the database query I think. Looks good to me in any case!

@tomhughes tomhughes merged commit 02ac7ab into openstreetmap:master Jan 29, 2025
22 checks passed
@AntonKhorev AntonKhorev deleted the issue-reportes-pluck branch January 30, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants