-
Notifications
You must be signed in to change notification settings - Fork 985
Advanced preferences, language dropdown in basic preferences #6024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tomhughes
merged 13 commits into
openstreetmap:master
from
AntonKhorev:advanced-preferences
Jun 1, 2025
Merged
Advanced preferences, language dropdown in basic preferences #6024
tomhughes
merged 13 commits into
openstreetmap:master
from
AntonKhorev:advanced-preferences
Jun 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
c54a9df
to
64b41a8
Compare
tomhughes
reviewed
May 18, 2025
ca2db20
to
4bfe88b
Compare
4bfe88b
to
2e7e70b
Compare
tomhughes
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a static file works as well at least for now, so I think this is good to merge, thaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to get #5201 to a mergeable state, but its language dropdown is in suboptimal state. So I decided to take a second attempt at #4461 which also has a language selector. If the attempt is successful, the selector can be reused in #5201.
The problems in #5201 with the language selector were:
The list in this PR is generated using this idea #5201 (comment), by reading native language names from comments in yml files. If we're not sure whether these comments are going to stay (the files are updated by TranslateWiki), we can dump them to some other file and read from there (UPD: done). Note that the UI language set differs from the diary language set in
config/languages.yml
. The resulting language dropdown shows native language names in case/diactric-insensitive order.Fixes #2581 by showing all available UI languages in a dropdown. You might still want to specify other languages for displaying name tags, that's what the language input on the Advanced Preferences page is for. I tried putting everyting on one page, but that complicates the user interface as you can see in #4461. A one-page solution would require either showing two language inputs at the same time or adding some button to switch between them, requiring javascript. The solution here doesn't require extra javascript.