Skip to content

Move layer definitions to pane controllers #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

hlfan
Copy link
Contributor

@hlfan hlfan commented May 29, 2025

Closes #5616 as a partial spiritual successor of #4335

@hlfan hlfan force-pushed the erb-sidebar branch 4 times, most recently from dbf14db to 55c1d86 Compare June 3, 2025 23:40
@AntonKhorev
Copy link
Collaborator

Is it possible to split this pull request per each sidebar pane? For example, to make a PR that moves only the map key first?

@hlfan
Copy link
Contributor Author

hlfan commented Jun 15, 2025

Sure, the map key sidebar pane content loading update would need to be merged before the other panes' PRs as they would depend on that.

@hlfan hlfan marked this pull request as draft June 15, 2025 06:52
@tomhughes
Copy link
Member

I mean it is already split into separate commits I think and I did have a quick look at it reviewing each commit but I've been meaning to come back and have a better look... As I recall my main question was whether the URLs should all be at the top level or should be under some common prefix.

@hlfan hlfan marked this pull request as ready for review June 15, 2025 07:23
@hlfan
Copy link
Contributor Author

hlfan commented Jun 15, 2025

under some common prefix

Good point, what do you think of "/panes/{pane}"?

@hlfan hlfan mentioned this pull request Jun 15, 2025
This was referenced Jun 15, 2025
@hlfan hlfan marked this pull request as draft June 15, 2025 14:54
@hlfan hlfan mentioned this pull request Jun 17, 2025
@github-actions github-actions bot removed the big-pr label Jun 22, 2025
@hlfan hlfan changed the title Move html from javascript to views Move layer definitions to pane controllers Jun 22, 2025
@hlfan hlfan marked this pull request as ready for review June 22, 2025 16:39
@hlfan
Copy link
Contributor Author

hlfan commented Jun 22, 2025

A little bit more cleaning up the HTML by putting the layer definitions in the pane controller like how also the legend is prepared. Then I think the structure is clean enough to also close the underlying issue.

@tomhughes
Copy link
Member

Looks good to me, thanks.

@tomhughes tomhughes merged commit 4d0861b into openstreetmap:master Jun 22, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move html from javascript to views
3 participants