Use noexcept versions of filesystem #829
Merged
Conversation
…file, remove, remove_all
There was a problem hiding this comment.
Pull Request Overview
This PR updates filesystem operations to use noexcept versions that accept an error_code parameter instead of throwing exceptions. The change improves error handling by allowing the code to handle filesystem errors gracefully rather than through exception propagation.
- Replaces throwing filesystem functions with noexcept versions that use boost::system::error_code
- Updates filesystem operations including exists, is_directory, is_regular_file, remove, and remove_all
- Maintains existing logic while improving error handling robustness
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| WorkflowController.cpp | Updates measure directory existence check and removal to use error_code |
| BCLMeasureDialog.cpp | Updates measure directory existence checks in folder creation logic |
| ScriptItem.cpp | Updates database file existence and removal operations |
| ScheduleFileInspectorView.cpp | Updates file existence check for schedule file validation |
| ResultsTabView.cpp | Updates directory existence checks for results searching |
| OSItem.cpp | Updates path existence check in item creation |
| OSDocument.cpp | Updates weather file path validation and removal operations |
| LocationTabView.cpp | Updates weather file removal with noexcept version |
| ApplyMeasureNowDialog.cpp | Updates file existence check for reload path validation |
| OpenStudioApp.cpp | Updates various filesystem checks including QtWebEngine path and DView validation |
| PathWatcher.cpp | Updates file/directory existence checks in path watching functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use noexcept versions of filesystem exists, is_directory, is_regular_file, remove, remove_all
Fixes #828