Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multipath: display the correct configuration when dumpping config #88

Closed
wants to merge 1 commit into from
Closed

multipath: display the correct configuration when dumpping config #88

wants to merge 1 commit into from

Conversation

Cav4ever
Copy link

@Cav4ever Cav4ever commented Jun 21, 2024 •
edited
Loading

"multipath -t" and "multipath -T" might show the wrong multipathd configuration items "retrigger_tries" and "force_sync". Make sure they don't.

I've already sent this patch to the mailing list for multipath-tools(dm-devel@lists.linux.dev).
https://lore.kernel.org/dm-devel/tencent_FE02DEB8FF48DD9EE156F288BCE172E25709@qq.com

@mwilck
Copy link
Contributor

mwilck commented Jun 21, 2024

This doesn't make sense. The changes affect only multipath's internal conf variable, which is never written back, and ceases to exist when multipath terminates.

@Cav4ever Cav4ever force-pushed the master-multipath-do-not-change-configuration-when-dumpping-config branch from 53cce61 to df090f6 Compare June 24, 2024 01:29
@Cav4ever
Copy link
Author

This doesn't make sense. The changes affect only multipath's internal conf variable, which is never written back, and ceases to exist when multipath terminates.

@mwilck My previous description was a bit ambiguous, so I'll describe it more clearly now.
"multipath -t" and "multipath -T" are used to dump multipathd configurations. But now, "multipath -t" and "multipath -T" might show the wrong multipathd configuration items "retrigger_tries" and "force_sync". Make sure they don't.
image

@Cav4ever Cav4ever changed the title multipath: do not change configuration when dumpping config multipath: display the correct configuration when dumpping config Jun 24, 2024
@Cav4ever
Copy link
Author

@mwilck
I see this patch has beeen taged with "Reviewed-by" by Benjamin Marzinski.
https://lore.kernel.org/dm-devel/ZnmY-Mu2hcmU_4Qm@redhat.com/
Will you commit this patch to openSUSE/multipath-tools sometime in the future?

multipath: display the correct configuration when dumpping config
df2f7bf 
"multipath -t" and "multipath -T" might show the wrong
multipathd configuration items "retrigger_tries" and
"force_sync". Make sure they don't.

Signed-off-by: Kou Wenqi <kouwenqi@kylinos.cn>
@Cav4ever Cav4ever force-pushed the master-multipath-do-not-change-configuration-when-dumpping-config branch from df090f6 to df2f7bf Compare August 13, 2024 02:38
@Cav4ever
Copy link
Author

@mwilck
I have noticed your review record on the mailing list for multipath-tools.
Thanks for your review and revised opinion.
I haved sent the updated patch to the mailing list: https://lore.kernel.org/dm-devel/tencent_C349DF9EE757FA8936E17CE2F90388B8B909@qq.com/

The patch on github has also been synchronized with the changes.

@mwilck
Copy link
Contributor

mwilck commented Aug 13, 2024 •
edited
Loading

Thanks! I've applied this to https://github.com/openSUSE/multipath-tools/commits/queue/.

(I've taken the liberty to correct the typo "dumpping" while applying)

@Cav4ever
Copy link
Author

Thanks! I've applied this to https://github.com/openSUSE/multipath-tools/commits/queue/.

(I've taken the liberty to correct the typo "dumpping" while applying)

Thanks for fixing my spelling mistake.

@Cav4ever Cav4ever mentioned this pull request Aug 16, 2024
Merged
@cvaroqui cvaroqui closed this in #94 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cav4ever @mwilck