Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd-tmpfiles-setup.service #98

Closed
wants to merge 1 commit into from

Conversation

foolstrong
Copy link

@foolstrong foolstrong commented Sep 9, 2024

In some case, multipath-tools is build base on runtimedir=/var/run, but run in environment that /var/run is symlink to /run, add after=systemd-tmpfiles-setup.service ensure that the /var/run symlink created already when the service is started.

fix #95

In some case, multipath-tools is build base on runtimedir=/var/run, but run in environment that /var/run is symlink to /run, add after=systemd-tmpfiles-setup.service ensure that the /var/run symlink created already when the service is started.
Copy link

github-actions bot commented Sep 9, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

tmpfiles

Previously acknowledged words that are now absent sdc 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:foolstrong/multipath-tools.git repository
on the master branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/opensvc/multipath-tools/actions/runs/10767949559/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (255) from .github/actions/spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:php/dict/php.txt 1689 13 3
cspell:node/dict/node.txt 891 14 2
cspell:python/src/python/python-lib.txt 2417 10 1
cspell:golang/dict/go.txt 2099 7 1
cspell:k8s/dict/k8s.txt 153 6 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:php/dict/php.txt
          cspell:node/dict/node.txt
          cspell:python/src/python/python-lib.txt
          cspell:golang/dict/go.txt
          cspell:k8s/dict/k8s.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''

@mwilck
Copy link
Contributor

mwilck commented Sep 9, 2024

This is wrong. systemd-tmpfiles-setup.service starts After=local-fs.target, which introduces an ordering cycle, as multipathd.service starts before local-fs-pre.target.

That said, we do have a problem here, because multipathd requires that /run/multipath exists, and we currently rely on systemd-tmpfiles-setup.service to create it for us. But this problem needs to be fixed be other means.

Cc: @bmarzins

@foolstrong
Copy link
Author

we have other way to fix it?

@mwilck
Copy link
Contributor

mwilck commented Sep 9, 2024

See #95 (comment)

@mwilck
Copy link
Contributor

mwilck commented Sep 9, 2024

we have other way to fix it?

Yes, make runtimedir=/run. If that still doesn't work, please report back.

@foolstrong foolstrong closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The multipathd.service startup failure
2 participants