Skip to content

docs: several fixes in docstrings #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2023
Merged

docs: several fixes in docstrings #170

merged 4 commits into from
Oct 16, 2023

Conversation

d0choa
Copy link
Collaborator

@d0choa d0choa commented Oct 13, 2023

Trivial fixes. I thought we were picking up this kind of errors somewhere in the precommits but it doesn't seem to be the case.

@d0choa d0choa requested a review from DSuveges October 13, 2023 13:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #170 (84e8de5) into main (cc1f636) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          67       67           
  Lines        1459     1459           
=======================================
  Hits         1324     1324           
  Misses        135      135           
Files Coverage Δ
src/otg/config.py 100.00% <100.00%> (ø)
src/otg/datasource/finngen/study_index.py 100.00% <ø> (ø)
src/otg/datasource/intervals/andersson.py 100.00% <ø> (ø)
src/otg/datasource/intervals/javierre.py 100.00% <100.00%> (ø)
src/otg/datasource/intervals/jung.py 100.00% <100.00%> (ø)
src/otg/datasource/intervals/thurman.py 100.00% <100.00%> (ø)
src/otg/v2g.py 66.66% <100.00%> (ø)

Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm quite sure it is not Thurnman but Thurman. This name is wrongly spelled across the repo. Could you fix them as well? It's very marginal detail, however fits well into the scope of the PR.

@d0choa d0choa requested a review from DSuveges October 16, 2023 08:53
@d0choa
Copy link
Collaborator Author

d0choa commented Oct 16, 2023

Thurman instead of Thurnman changes implemented. Tests passing

@d0choa d0choa self-assigned this Oct 16, 2023
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@DSuveges DSuveges merged commit dc5d2b6 into main Oct 16, 2023
@DSuveges DSuveges deleted the do_docstring_fixes branch October 16, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants