Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing odds ratio, and confidence intervals from the schema #267

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Removing odds ratio, and confidence intervals from the schema #267

merged 2 commits into from
Nov 21, 2023

Conversation

DSuveges
Copy link
Contributor

No description provided.

tskir
tskir approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@tskir tskir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Makes sense in line with the previous changes

@tskir tskir merged commit 48c03f9 into main Nov 21, 2023
@tskir tskir deleted the ds_3039_sumstats_update branch November 21, 2023 17:35
@ireneisdoomed
Copy link
Contributor

For the record, I've successfully run the step with the changes.
25% of the associations lack 'beta' effect size data. The previous StudyLocus also showed this, where missing betas also meant missing odds ratios. So we're not losing any information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskir tskir tskir approved these changes

@ireneisdoomed ireneisdoomed Awaiting requested review from ireneisdoomed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DSuveges @ireneisdoomed @tskir