Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local SSD attachment syntax #269

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix local SSD attachment syntax #269

merged 2 commits into from
Nov 22, 2023

Conversation

tskir
Copy link
Contributor

@tskir tskir commented Nov 22, 2023

My apologies, there's a missing field in the chain which slipped through refactors and rebases. I've verified that this now works and the cluster is created without an issue.

Please feel free to merge this PR immediately once approved.

@codecov-commenter
Copy link

Codecov Report

Merging #269 (9358cd9) into main (e5e9f29) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files          85       85           
  Lines        1920     1920           
=======================================
  Hits         1650     1650           
  Misses        270      270           
Files Coverage Δ
src/airflow/dags/common_airflow.py 100.00% <100.00%> (ø)

@tskir tskir requested a review from DSuveges November 22, 2023 11:53
@DSuveges DSuveges merged commit 24addab into main Nov 22, 2023
@tskir tskir deleted the tskir-fix-local-ssds branch November 22, 2023 12:02
@d0choa
Copy link
Collaborator

d0choa commented Nov 22, 2023

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants