Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try to fix Codecov configuration #306

Closed
wants to merge 1 commit into from

Conversation

tskir
Copy link
Contributor

@tskir tskir commented Dec 5, 2023

There was this dependabot PR which I confirmed was working and merged: #301

The tests were passing in the PR, but after merging they failed in the main branch with the following error message:

[2023-12-04T20:52:25.943Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Could not find a repository associated with upload token ***', code='not_found')}

Our project indeed has a CODECOV_TOKEN secret, which is picked up by the workflow. It was updated 15 hours ago, and it looks like the tests have started failing since then.

Codecov documentation mentions (first question, last paragraph) that this token is not required for public repositories, so my idea is that by removing this entirely we might resolve the problem.

@tskir tskir requested a review from d0choa December 5, 2023 08:58
@tskir
Copy link
Contributor Author

tskir commented Dec 5, 2023

Ah, no, I think I've got it. Despite what the documentation says (unexpected right?), it looks like starting with Codecov v4 upload token is actually required even for public repositories. I've now updated it and restarted the test for the main branch, see if it works

@tskir
Copy link
Contributor Author

tskir commented Dec 5, 2023

Yes, that helped!

image

Closing this PR as no longer necessary.

@tskir tskir closed this Dec 5, 2023
@tskir tskir deleted the tskir-fix-codecov-configuration branch December 5, 2023 09:27
@d0choa
Copy link
Collaborator

d0choa commented Dec 5, 2023

Indeed, I updated the token yesterday to see if that resolved the issues. The Codecov upload is a bit of a hit-and-miss at the moment. They have been recently acquired and it doesn't seem to be in a stable state. I've been monitoring whether people will be jumping out or using any alternative, but there is some inertia at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants