-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l2g): implement variant consequence features from VEP #805
Conversation
…ity score as class attribute
) | ||
.join(consequences_dataset, "variantId") | ||
) | ||
elif isinstance(study_loci_to_annotate, L2GGoldStandard): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still have L2GGoldStandard? Isn't it going to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed offline, we'll do that once we tackle opentargets/issues#3525
f.when( | ||
f.col("biotype") == "protein_coding", f.col(local_feature_name) | ||
) | ||
).over(Window.partitionBy("studyLocusId")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we assign the genes for this studyLocusId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genes come from VEP. It's the genes of the transcript that the variant overlaps with in a 500kb window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For variantId - yes, but we have many varintIds in one studyLocusId. So just to be sure - we use the union across al varaintIds? And if varintId is not assigned to geneId we assume its VEP score is 0?
…s class attribute
…gets/gentropy into il-csq_to_score_property
Approved |
✨ Context
Closes opentargets/issues#3554
🛠 What does this PR implement
🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?