fix: empty inSilicoPredictors object in GnomAD variant index #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The branch runs, GnomAD variant index generated here: |
There was a problem hiding this comment.
The logic is OK, but maybe I am missing context. I thought these were coming from VEP directly, not from gnomAD?
There are two in-silico predictors that I couldn't get VEP to do: pangolin and spliceai. These are extracted from GnomAD. I know, this is quite an overcomplication of the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
The way we could extract in-silico predictors from the hail table of GnomAD variants, lead to empty rows, where no predicted scores were available. Upon creation, a filter is applied to drop these variants. This PR has no effect on schema, it is purely motivated by the desire to making the variant index dataset cleaner.