-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve fixture definition by constraining dataset IDs #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ireneisdoomed
requested review from
project-defiant
and removed request for
project-defiant
December 16, 2024 12:32
…hanging nullability status
…-better-fixtures
…hanging nullability status
@@ -67,6 +67,18 @@ class StudyIndex(Dataset): | |||
A study index dataset captures all the metadata for all studies including GWAS and Molecular QTL. | |||
""" | |||
|
|||
VALID_TYPES = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Care to say that this should be an enum (in the future)
project-defiant
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
We use
dbldatagen
to build mock dataframes given a specific schema. We use this mock dataframes to test that the logic returns data in the correct format. For content testing, we have to manually define how we want the data to look like.In a recent PR, there is one test that is failing because the tested logic involves joining different mock datasets. The join doesn't return any common rows, therefore the test fails.
This PR aims to make the automatically generated datasets more useful by adding a constraint in the ID fields of each dataset so that joins will be successful.
After this PR is merged, the failing test in the above mentioned PR will no longer fail.
🛠 What does this PR implement
🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?