-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: multiple python version support with latest pyspark and hail #974
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
90e6028
chore(pyspark): update to 3.5.X
SzymonSzyszkowski 630c0c9
chore: fix doctest syntax
SzymonSzyszkowski 1dbe1b0
chore: bump temurin version to 11
SzymonSzyszkowski bcf0b9a
feat: allow multiple python versions
4d3380a
feat: python matrix for gha
28b3e2c
chore: pre-commit auto fixes [...]
pre-commit-ci[bot] 9cc2c78
Merge branch 'dev' into pyspark-bump
project-defiant fbaa8d9
chore: typos
7f416ed
chore: fix python version in setup dev script
5a9cd8f
fix: attempt to fix the 3.11 tests
c46cdab
fix: set the session correctly in variant_index_config
18c66b1
Revert "chore: fix doctest syntax"
def0fbb
chore: update dependencies
4eabc51
Revert "Revert "chore: fix doctest syntax""
c350211
chore: bump image to 2.2
8c2fa2b
chore: update lock files
1719b5c
build: poetry cleanup
c45ac1c
build: uv checks droped
1fccce6
chore: fix dockerfile and install test deps
4c1efbd
build(uv): add all dependencies to run tests
1e913a8
Merge branch 'dev' into pyspark-bump
project-defiant 08e03e3
chore: fix test issue with rounding error
f9fc356
chore: fix dependency version lower bounds
f1ff1f9
chore: add .python-version file to ignored
98d464d
build: new setup
aa64db9
build: new setup
570e33e
build: new setup
89a9c34
build: new setup
2db0610
build: new setup
b392368
revert: bring back initialization actions
2329a8a
chore: align variable name
04c2ed2
chore: update pre-commit python version
979325d
chore: docs update
3eb7d55
Merge branch 'dev' into pyspark-bump
project-defiant 79022b9
feat: more complex uv installation
SzymonSzyszkowski 9adc76a
feat: notify to source shellrc file when installing uv
SzymonSzyszkowski 7d10b63
fix: checks
SzymonSzyszkowski a17290d
chore: debug gha
SzymonSzyszkowski 79de16b
chore: debug gha
SzymonSzyszkowski e7d5cd8
feat: debug gha
SzymonSzyszkowski f4ab0d0
feat: debug gha
SzymonSzyszkowski 3bc1318
feat: debug gha
SzymonSzyszkowski a82b86c
feat: force user shell
SzymonSzyszkowski 09b83a8
feat: gha debug
SzymonSzyszkowski 640f493
feat: gha debug
SzymonSzyszkowski 4a2018a
feat: gha debug
SzymonSzyszkowski e3ea829
feat: gha debug
SzymonSzyszkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,5 @@ site/ | |
.coverage* | ||
wandb/ | ||
hail*.log | ||
.python-version | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,20 @@ | ||
FROM python:3.10-bullseye | ||
|
||
RUN apt-get update \ | ||
&& apt-get clean \ | ||
&& apt-get install -y openjdk-11-jdk \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
RUN apt-get update && \ | ||
apt-get clean && \ | ||
apt-get install -y openjdk-11-jdk && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
ENV POETRY_NO_INTERACTION=1 \ | ||
POETRY_VIRTUALENVS_IN_PROJECT=1 \ | ||
POETRY_VIRTUALENVS_CREATE=1 \ | ||
POETRY_CACHE_DIR=/tmp/poetry_cache \ | ||
JAVA_HOME=/usr | ||
ENV JAVA_HOME=/usr | ||
|
||
RUN pip install poetry>=2.0.0 | ||
RUN pip install uv | ||
WORKDIR /app | ||
|
||
COPY pyproject.toml poetry.lock ./ | ||
COPY pyproject.toml uv.lock ./ | ||
RUN touch README.md | ||
|
||
RUN poetry config installer.max-workers 10 | ||
RUN poetry install --without dev,docs,tests --no-root --no-interaction --no-ansi -vvv && rm -rf $POETRY_CACHE_DIR | ||
RUN uv sync | ||
|
||
COPY src ./src | ||
|
||
RUN poetry install --without dev,docs,tests | ||
|
||
ENTRYPOINT ["poetry", "run", "gentropy"] | ||
ENTRYPOINT ["uv", "run", "gentropy"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test this yourself, but the current command goes idle without running any tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests still go ok on my side, although it seems that the long lookup, not sure why the dot helps here, assuming that we already add the
testpath(s)
to the pytest options, the dot just overwrites it. While testing your solution I got following errors cache related:This seems to be due to the fact that I have previously generated the docs that contain some test duplicate.
On the note of test collection speeds:
in the first run the
site
dir is removed