fix: we can't parse things like 192.168.1.1:4000

[mkleene]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mkleene, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the AddressNormalizer failed to properly process network addresses provided without a scheme, such as direct IP addresses or hostnames. The core change involves enhancing the URI parsing mechanism to be more resilient, allowing the system to correctly infer and apply appropriate schemes (http/https) and default ports to these malformed inputs. This ensures consistent and reliable address normalization across various input formats.

Highlights

• Improved URI Parsing: The AddressNormalizer now correctly handles URLs provided as raw IP addresses or hostnames without an explicit scheme (e.g., 192.168.1.1:400), which previously caused parsing errors.
• New Helper Method for Robust Parsing: A private static helper method, getInitialUri, has been introduced to encapsulate the URI parsing logic. This method attempts to parse the URI directly and, if it fails due to a missing scheme, retries by prepending a 'fake://' scheme to allow the URI class to correctly identify the host and port.
• Expanded Test Coverage: New test cases have been added to AddressNormalizerTest to specifically validate the correct normalization of IP addresses, both with and without specified ports, for both secure (HTTPS) and insecure (HTTP) connections.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug that prevented parsing of schemeless URIs with IP addresses, such as 192.168.1.1:400. The fix introduces a new helper method, getInitialUri, which cleverly retries parsing by prepending a temporary scheme if the initial attempt fails. This is a good approach and is well-supported by the new test cases. I have one suggestion to enhance the error reporting in the new helper method to ensure that the most relevant exception details are preserved, which will aid in debugging potential parsing issues in the future.

[gemini-code-assist]

In the case of a second URISyntaxException, the exception e is discarded, and initialThrown is used as the cause for the SDKException. However, the second exception e might contain more specific details about why the URL is malformed, especially after we've attempted to fix a missing scheme. For instance, with an input like 1.2.3.4:badport, initialThrown would indicate an invalid scheme, while e would point to the invalid port number, which is the more precise error.

To improve diagnostics, it would be beneficial to preserve both exceptions. You can achieve this by adding e as a suppressed exception to initialThrown.

            initialThrown.addSuppressed(e);
            throw new SDKException("error parsing url [" + urlString + "]", initialThrown);

[mkleene]

/gemini review

[gemini-code-assist]

Code Review

This pull request fixes an issue where URLs consisting of an IP address and port could not be parsed correctly. This is achieved by introducing a new getInitialUri method that attempts to parse the URL, and if that fails, retries by prepending a fake scheme. This is a good approach to handle scheme-less URIs. The changes are well-tested with new test cases for IP-based addresses. I have one suggestion to refactor the new getInitialUri method for better readability and to fix a minor typo in a comment.

[sonarqubecloud]

Quality Gate failed

Failed conditions
7 Security Hotspots

See analysis details on SonarQube Cloud