-
Notifications
You must be signed in to change notification settings - Fork 2
chore(sdk): update grpc, error-prone-annotations, and guava versions #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Scott Hamrick <2623452+cshamrick@users.noreply.github.com>
Summary of ChangesHello @cshamrick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on routine dependency maintenance by updating several key library versions within the SDK's "pom.xml" file. The updates include gRPC, Error Prone Annotations, and Guava, ensuring the project benefits from the latest bug fixes, performance enhancements, and features provided by these updated dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several key dependencies: gRPC, error-prone-annotations, and Guava. While keeping dependencies up-to-date is a good practice, I've identified a critical compatibility issue related to the gRPC update. The version of protobuf-java used in the project is not compatible with the new gRPC version, which can lead to runtime failures. I've left a specific comment with details on how to address this. The other version bumps for error-prone-annotations and guava appear to be safe.
X-Test Results✅ js-v0.4.34 |
elizabethhealy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the gemini comment seems like it probably isnt relevant given were already using protobuf >=4
|
X-Test Results✅ js-v0.4.34 |



No description provided.