chore(ci): use yaml anchors in checks job for common reused actions #2900
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
actionlint
🚫 [actionlint] reported by reviewdog 🐶
specifying action "" in invalid format because ref is missing. available formats are "{owner}/{repo}@{ref}" or "{owner}/{repo}/{path}@{ref}" [action]
platform/.github/workflows/checks.yaml
Line 557 in 9a4da1d
🚫 [actionlint] reported by reviewdog 🐶
expected scalar node for string value but found alias node with "" tag [syntax-check]
platform/.github/workflows/checks.yaml
Line 560 in 9a4da1d
🚫 [actionlint] reported by reviewdog 🐶
specifying action "" in invalid format because ref is missing. available formats are "{owner}/{repo}@{ref}" or "{owner}/{repo}/{path}@{ref}" [action]
platform/.github/workflows/checks.yaml
Line 560 in 9a4da1d
| contents: read | ||
| name: integration tests | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: *ubuntu-runner |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
"runs-on" section is alias node but mapping node is expected [syntax-check]
| TLS_ENABLED: "true" | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| - uses: *actions-checkout |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
expected scalar node for string value but found alias node with "" tag [syntax-check]
| TLS_ENABLED: "true" | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| - uses: *actions-checkout |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
specifying action "" in invalid format because ref is missing. available formats are "{owner}/{repo}@{ref}" or "{owner}/{repo}/{path}@{ref}" [action]
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: *actions-setup-go |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
expected scalar node for string value but found alias node with "" tag [syntax-check]
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: *actions-setup-go |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
specifying action "" in invalid format because ref is missing. available formats are "{owner}/{repo}@{ref}" or "{owner}/{repo}/{path}@{ref}" [action]
| input: service | ||
| against: "https://github.com/opentdf/platform.git#branch=${{ github.event.pull_request.base.ref || github.base_ref || 'main' }},subdir=service" | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: *actions-setup-go |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
expected scalar node for string value but found alias node with "" tag [syntax-check]
| input: service | ||
| against: "https://github.com/opentdf/platform.git#branch=${{ github.event.pull_request.base.ref || github.base_ref || 'main' }},subdir=service" | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: *actions-setup-go |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
specifying action "" in invalid format because ref is missing. available formats are "{owner}/{repo}@{ref}" or "{owner}/{repo}/{path}@{ref}" [action]
| - tests-bdd | ||
| - otdfctl-test | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: *ubuntu-runner |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
"runs-on" section is alias node but mapping node is expected [syntax-check]
| contents: read | ||
| name: license check | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: *ubuntu-runner |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
"runs-on" section is alias node but mapping node is expected [syntax-check]
| runs-on: *ubuntu-runner | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| - uses: *actions-checkout |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
expected scalar node for string value but found alias node with "" tag [syntax-check]
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: &actions-setup-go actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 |
Check failure
Code scanning / zizmor
runtime artifacts potentially vulnerable to a cache poisoning attack Error
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: &actions-setup-go actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 |
Check failure
Code scanning / zizmor
runtime artifacts potentially vulnerable to a cache poisoning attack Error
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: &actions-setup-go actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 |
Check failure
Code scanning / zizmor
runtime artifacts potentially vulnerable to a cache poisoning attack Error
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 | ||
| - uses: &actions-setup-go actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 |
Check failure
Code scanning / zizmor
runtime artifacts potentially vulnerable to a cache poisoning attack Error
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Proposed Changes
checks.yamlworkflow, we should use a yaml anchor, now GA in GHAChecklist
Testing Instructions