Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): add a test that has assertion statement values as objects #245

Merged
merged 11 commits into from
Jan 29, 2025

Conversation

mkleene
Copy link
Contributor

@mkleene mkleene commented Jan 24, 2025

Filewatcher sets assertion values as JSON objects like

"statement": {
  "format": "string",
  "value": {
    "context": {
      "@base": "urn:nato:stanag:5636:A:1:elements:json"
    },
    "ocl": {
      "catl": [
        {
          "name": "Releasable To",
          "type": "P",
          "vals": [
            "usa"
          ]
        }
      ],
      "pol": "2ccf11cb-6c9a-4e49-9746-a7f0a295945d",
      "cls": "SECRET",
      "dcr": "2024-12-17T13:00:52Z"
    }
  }

this adds a test that makes sure that all SDKs can properly deserialize such manifests when they
have assertion verification disabled.

In order to make this work we needed to pass through an option that disables assertion verification.

Requires opentdf/platform#1833 and opentdf/java-sdk#219 to be
merged before it will pass

successful run against SDK branches: https://github.com/opentdf/tests/actions/runs/12992325319/job/36231902231

@mkleene mkleene changed the title add a test that has assertion statement values as objects fix(sdk): add a test that has assertion statement values as objects Jan 27, 2025
@mkleene mkleene marked this pull request as ready for review January 27, 2025 15:58
@mkleene mkleene requested review from a team as code owners January 27, 2025 15:58
Copy link
Member

@elizabethhealy elizabethhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do a run with the java and go branches to verify the changes?

@mkleene
Copy link
Contributor Author

mkleene commented Jan 28, 2025

can you do a run with the java and go branches to verify the changes?

It's in the comment

@mkleene mkleene merged commit f3c156e into main Jan 29, 2025
5 checks passed
@mkleene mkleene deleted the add-test-with-object-assertions branch January 29, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants