Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Assertion signing keys and verification #398

Closed
wants to merge 44 commits into from
Closed

feat(cli): Assertion signing keys and verification #398

wants to merge 44 commits into from

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Dec 9, 2024 •
edited
Loading

Add option to the cli to pass in assertion verification keys, handles assertion signing keys passed in on encrypt

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@elizabethhealy elizabethhealy changed the title feat(cli): Assertion signing keys and verification feat(cli): Assertion signing keys and verification (otdfctl) Dec 9, 2024
@elizabethhealy elizabethhealy changed the title feat(cli): Assertion signing keys and verification (otdfctl) feat(cli): Assertion signing keys and verification Dec 9, 2024
@github-actions GitHub Actions
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@github-actions GitHub Actions
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@elizabethhealy elizabethhealy marked this pull request as ready for review December 10, 2024 15:07
@elizabethhealy elizabethhealy requested a review from a team as a code owner December 10, 2024 15:07
dmihalcik-virtru
dmihalcik-virtru previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling error, otherwise good

lib/tdf3/src/client/builders.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

elizabethhealy and others added 18 commits December 13, 2024 12:06
@elizabethhealy
add default
df2dbec 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
🤖 🎨 Autoformat
2492b5c 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
fix ts errors
24ac166 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
🤖 🎨 Autoformat
eeac9e0 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
fix assertion verification structure validation
e00e58a 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
🤖 🎨 Autoformat
73907d6 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
uppercase keys
3701191 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
🤖 🎨 Autoformat
73ccd7b 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
allow for passing file instead, avoid keys in command line
2a6f065 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
🤖 🎨 Autoformat
e98cabf 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
typo fix
decd1c6 
Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@dmihalcik-virtru @elizabethhealy
chore!(sdk): remove v1 support (#393)
d002896 
- Removes axios and XHR support - all requests now use fetch
- Removes `v1` path support for rewrap and public key
- Removes `entityObject`
- Removes AppIdAuthProvider
- Removes `upsert`

Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@dmihalcik-virtru @elizabethhealy
🆙 0.2.0 minor autobump (#400)
891fe86 
This is because indicate that v 0.2.x and later will:

- not support v1 (entity object, etc.)
- will add a simplified and unified API for TDF manipulation, sharing patterns between different container formats
- other radical changes tbd

Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@dmihalcik-virtru @elizabethhealy
chore(sdk): Prefer named, direct exports (#401)
5dd9610 
- For code in the src/tdf folder, replace all default exports with named ones.
- Should prevent confusion when grepping for code
- While here, also deletes dead/unused code as found

Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@dmihalcik-virtru @elizabethhealy
chore(sdk): Removes base64-js dep (#402)
bf53a46 
We already have an internal library that provides this

Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@dmihalcik-virtru @elizabethhealy
feat!(sdk): Remove 'toFile' method (#403)
6194a13 
This removes a dependency on streamsaver.js. The equivalent function to this method is now viewable in the `App.tsx` file:

```ts
async function toFile(
  stream: ReadableStream<Uint8Array>,
  filepath = 'download.tdf',
  options?: {
    encoding?: BufferEncoding;
    signal?: AbortSignal;
  }
): Promise<void> {

  const fileStream = streamsaver.createWriteStream(filepath, {
    writableStrategy: { highWaterMark: 1 },
    readableStrategy: { highWaterMark: 1 },
  });

  return stream.pipeTo(fileStream, options);
}
```

Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@dmihalcik-virtru @elizabethhealy
chore(sdk): Refactor old clients to own file (#405)
3404b5d 
To prevents loops in package imports with new clients loading them

Signed-off-by: Elizabeth Healy <ehealy@virtru.com>
@elizabethhealy
Merge branch 'assertion-verification-cli' of https://github.com/opent…
9831b91 
…df/web-sdk into assertion-verification-cli
@elizabethhealy
Copy link
Member Author

ignore extra commits, im trying to sign the autoformat unverified ones

dmihalcik-virtru
dmihalcik-virtru previously approved these changes Dec 16, 2024
View reviewed changes
cli/src/cli.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
61.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@elizabethhealy elizabethhealy mentioned this pull request Dec 16, 2024
Merged
@elizabethhealy
Copy link
Member Author

elizabethhealy commented Dec 16, 2024 •
edited
Loading

moved to different PR bc unsigned commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmihalcik-virtru dmihalcik-virtru dmihalcik-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizabethhealy @dmihalcik-virtru