chore!(sdk): Remove html wrapper creation#406
Merged
dmihalcik-virtru merged 3 commits intomainfrom Dec 13, 2024
Merged
Conversation
Member
dmihalcik-virtru
commented
Dec 12, 2024
dmihalcik-virtru
commented
- still allow reading html wrapped files, for transitional support
- still allow reading html wrapped files, for transitional support
elizabethhealy
previously approved these changes
Dec 13, 2024
| scope = { attributes: [], dissem: [] }, | ||
| autoconfigure, | ||
| source, | ||
| asHtml = false, |
Member
There was a problem hiding this comment.
why remove the false default?
Member
Author
There was a problem hiding this comment.
We no longer need to assert it is === false as that is the default (and I think has been for some time)
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
Member
Author
dmihalcik-virtru
left a comment
dmihalcik-virtru
left a comment
There was a problem hiding this comment.
PTAL as I had to resolve a merge conflict
| scope = { attributes: [], dissem: [] }, | ||
| autoconfigure, | ||
| source, | ||
| asHtml = false, |
Member
Author
There was a problem hiding this comment.
We no longer need to assert it is === false as that is the default (and I think has been for some time)
elizabethhealy
approved these changes
Dec 13, 2024
Signed-off-by: David Mihalcik <dmihalcik@virtru.com>
dmihalcik-virtru
force-pushed
the
feature/no-html-wrapping
branch
from
90bfa3d to
a2c2e53
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.