Remove process_events() calls if they precede is_success (which pro…

…cesses the events anyway)
opentensor · Dec 16, 2024 · 0bf40c7 · 0bf40c7
1 parent 4a8d06f
commit 0bf40c7
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 12 deletions.
diff --git a/bittensor/core/async_subtensor.py b/bittensor/core/async_subtensor.py
@@ -1416,7 +1416,6 @@ async def sign_and_send_extrinsic(
             # We only wait here if we expect finalization.
             if not wait_for_finalization and not wait_for_inclusion:
                 return True, ""
-            await response.process_events()
             if await response.is_success:
                 return True, ""
             else:

diff --git a/bittensor/core/extrinsics/async_registration.py b/bittensor/core/extrinsics/async_registration.py
@@ -83,7 +83,6 @@ async def _do_pow_register(
         return True, None
 
     # process if registration successful, try again if pow is still valid
-    await response.process_events()
     if not await response.is_success:
         return False, format_error_message(error_message=await response.error_message)
     # Successful registration

diff --git a/bittensor/core/extrinsics/async_root.py b/bittensor/core/extrinsics/async_root.py
@@ -167,7 +167,6 @@ async def _do_set_root_weights(
     if not wait_for_finalization and not wait_for_inclusion:
         return True, "Not waiting for finalization or inclusion."
 
-    await response.process_events()
     if await response.is_success:
         return True, "Successfully set weights."
     else:

diff --git a/bittensor/core/extrinsics/async_transfer.py b/bittensor/core/extrinsics/async_transfer.py
@@ -56,7 +56,6 @@ async def _do_transfer(
         return True, "", "Success, extrinsic submitted without waiting."
 
     # Otherwise continue with finalization.
-    await response.process_events()
     if await response.is_success:
         block_hash_ = response.block_hash
         return True, block_hash_, "Success with response."

diff --git a/bittensor/core/extrinsics/async_weights.py b/bittensor/core/extrinsics/async_weights.py
@@ -73,7 +73,6 @@ async def _do_set_weights(
     if not wait_for_finalization and not wait_for_inclusion:
         return True, "Not waiting for finalization or inclusion."
 
-    await response.process_events()
     if await response.is_success:
         return True, "Successfully set weights."
     else:
@@ -200,7 +199,6 @@ async def _do_commit_weights(
     if not wait_for_finalization and not wait_for_inclusion:
         return True, None
 
-    await response.process_events()
     if await response.is_success:
         return True, None
     else:

diff --git a/bittensor/core/extrinsics/commit_reveal.py b/bittensor/core/extrinsics/commit_reveal.py
@@ -68,13 +68,10 @@ def _do_commit_reveal_v3(
     if not wait_for_finalization and not wait_for_inclusion:
         return True, "Not waiting for finalization or inclusion."
 
-    response.process_events()
     if response.is_success:
         return True, None
     else:
-        return False, format_error_message(
-            response.error_message
-        )
+        return False, format_error_message(response.error_message)
 
 
 def commit_reveal_v3_extrinsic(

diff --git a/bittensor/core/extrinsics/staking.py b/bittensor/core/extrinsics/staking.py
@@ -53,7 +53,6 @@ def _do_stake(
     if not wait_for_finalization and not wait_for_inclusion:
         return True
 
-    response.process_events()
     if response.is_success:
         return True
     else:

diff --git a/bittensor/core/extrinsics/unstaking.py b/bittensor/core/extrinsics/unstaking.py
@@ -52,7 +52,6 @@ def _do_unstake(
     if not wait_for_finalization and not wait_for_inclusion:
         return True
 
-    response.process_events()
     if response.is_success:
         return True
     else: