Fix multiprocessing POW errors and No Torch logging errors #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttensor.btlogging is a module, and thus does not contain the `error` function.
basfroman
previously approved these changes
Jul 27, 2024
|
Discovered the importance of mocking the correct object. PR is good to go. |
thewhaleking
changed the title
thewhaleking
changed the title
thealligatorking
approved these changes
Jul 29, 2024
basfroman
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The was a hidden error from the registration POW that was previously hidden, until logging was fixed in 54b7f3d. Fixes #2185. The
joinbeing called before termination was causing a Thread-2 exception because of the GIL (see: https://bugs.python.org/issue12488). Also includes a fix wherebittensor.btlogging.errorwas called instead ofbittensor.logging.error.