Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #2620

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

Fix typos #2620

wants to merge 5 commits into from

Conversation

Marcofann
Copy link

@Marcofann Marcofann commented Jan 31, 2025 •
edited
Loading

  • Fixed "commited" → "committed" in async_commit_reveal.py and commit_reveal.py.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Risks

Low – changes are minor typo fixes and do not affect functionality.

@thewhaleking thewhaleking self-requested a review January 31, 2025 15:27
thewhaleking
thewhaleking requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Marcofann, thanks for the PR. There's some issues however.

  1. PRs should be based off staging.
  2. arange is an array range, a function of NumPy. It is very different than arrange, which means to order something.

Please remove the NumPy stuff, and base your PR off staging.

@Marcofann Marcofann changed the base branch from master to staging February 1, 2025 12:51
@Marcofann
Copy link
Author

@thewhaleking Hi!

I've made the requested changes:

  1. The base branch is now staging.
  2. Removed the np.arange() change as requested.

Please let me know if anything else needs to be updated.

@thewhaleking thewhaleking requested a review from a team February 3, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-opentensor roman-opentensor roman-opentensor approved these changes

@ibraheem-opentensor ibraheem-opentensor ibraheem-opentensor approved these changes

@thewhaleking thewhaleking thewhaleking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Marcofann @thewhaleking @ibraheem-opentensor @roman-opentensor