Fast block improvements #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2024
Closed
roman-opentensor
approved these changes
Nov 23, 2024
| @@ -737,8 +736,12 @@ async def run_faucet_extrinsic( | |||
| # Attempt rolling registration. | |||
| attempts = 1 | |||
| successes = 1 | |||
| pow_result: Optional[POWSolution] | |||
There was a problem hiding this comment.
why you add this if we have pow_result=None in line 745?
line 745 should be more than enough since pow_result variable is using just within while loop.
There was a problem hiding this comment.
Just so mypy wouldn't yell at me on line 746 😅
ibraheem-opentensor
approved these changes
Nov 25, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.