Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue, when the block of the last stake/unstake was reset to the current block.
Removes
get_stakes_this_interval_for_coldkey_hotkey
andset_stakes_this_interval_for_coldkey_hotkey
byreplacing it with
try_increase_staking_counter
.For a getter,
get_stakes_this_interval_for_coldkey_hotkey
has an unwanted side effect of mutating the storage.set_stakes_this_interval_for_coldkey_hotkey
is just a storage setter.Both methods used only in
do_add_stake
anddo_remove_stake
.Replaces
StakeRateLimitExceeded
andUnstakeRateLimitExceeded
error variants withStakingRateLimitExceeded
as we don't separate rate limit logic and value between staking/unstaking.Related Issue(s)
Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly