Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staking counter #1093

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Fix staking counter #1093

merged 4 commits into from
Dec 16, 2024

Conversation

ales-otf
Copy link
Contributor

Description

  • Fixes the issue, when the block of the last stake/unstake was reset to the current block.

  • Removes get_stakes_this_interval_for_coldkey_hotkey and set_stakes_this_interval_for_coldkey_hotkey by
    replacing it with try_increase_staking_counter.

    For a getter, get_stakes_this_interval_for_coldkey_hotkey has an unwanted side effect of mutating the storage.

    set_stakes_this_interval_for_coldkey_hotkey is just a storage setter.

    Both methods used only in do_add_stake and do_remove_stake.

  • Replaces StakeRateLimitExceeded and UnstakeRateLimitExceeded error variants with StakingRateLimitExceeded as we don't separate rate limit logic and value between staking/unstaking.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ales-otf ales-otf self-assigned this Dec 12, 2024
@ales-otf ales-otf added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 12, 2024
@ales-otf ales-otf marked this pull request as ready for review December 12, 2024 22:07
@ales-otf ales-otf requested a review from unconst as a code owner December 12, 2024 22:07
@ales-otf ales-otf requested a review from a team December 12, 2024 22:08
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
@sam0x17 sam0x17 merged commit f7db79c into devnet-ready Dec 16, 2024
15 checks passed
@ales-otf ales-otf deleted the fix/stake-rate-limit branch December 16, 2024 19:27
This was referenced Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants